Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the conflict of the analysis modal correctly #2727

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

hamed-musallam
Copy link
Member

@hamed-musallam hamed-musallam commented Oct 26, 2023

the issue introduced by 8cb92df

close #2726

@hamed-musallam hamed-musallam linked an issue Oct 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c1657) 53.14% compared to head (a75cb93) 53.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
+ Coverage   53.14%   53.16%   +0.01%     
==========================================
  Files          51       51              
  Lines        2497     2498       +1     
  Branches       90       90              
==========================================
+ Hits         1327     1328       +1     
  Misses       1169     1169              
  Partials        1        1              
Files Coverage Δ
src/data/data1d/Spectrum1D/initiateDatum1D.ts 76.03% <100.00%> (ø)
src/data/data2d/Spectrum2D/initiateDatum2D.ts 95.08% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam force-pushed the fix-display-chart-not-working-anymore branch from d2fe048 to 7893487 Compare October 26, 2023 13:14
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a75cb93
Status: ✅  Deploy successful!
Preview URL: https://e0477e5f.nmrium.pages.dev
Branch Preview URL: https://fix-display-chart-not-workin.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the fix-display-chart-not-working-anymore branch from ff7f7ec to a75cb93 Compare October 26, 2023 14:01
@hamed-musallam hamed-musallam changed the title fix: display chart not working anymore fix: resolve the conflict of the analysis modal correctly Oct 26, 2023
@hamed-musallam hamed-musallam merged commit fe6a81c into main Oct 26, 2023
13 checks passed
@hamed-musallam hamed-musallam deleted the fix-display-chart-not-working-anymore branch October 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display chart not working anymore
1 participant